fix(context): guard nil local config before context switch#406
Open
Rahulatram321 wants to merge 1 commit into
Open
fix(context): guard nil local config before context switch#406Rahulatram321 wants to merge 1 commit into
Rahulatram321 wants to merge 1 commit into
Conversation
|
Welcome to the Microcks community! 💖 Thanks and congrats 🎉 for opening your first pull request here! Be sure to follow the pull request template or please update it accordingly. Hope you have a great time there! |
|
please pass the DCO |
Signed-off-by: rahulAtram <rahulatram0226@gmail.com>
Rahulatram321
force-pushed
the
fix/context-nil-guard
branch
from
0fb7f62 to
0b50f24
Compare
Contributor
Author
Thanks for the review and for flagging this. I’ve updated this PR by rewriting the commit(s) with DCO sign-off and force-pushed the branch. Signed-off-by: Rahul Atram rahulatram0226@gmail.com I also kept the scope unchanged to only the intended fix in this PR. |
Contributor
Author
|
Hi Sir,
Thank you for pointing this out.
I have updated this PR by rewriting the commit history with DCO sign-off
and force-pushing the branch.
All commits now include:
Signed-off-by: Rahul Atram ***@***.***>
The PR scope is unchanged and remains limited to the original fix only.
Could you please recheck once the DCO status updates?
Thanks again for your guidance.
Best,
Rahul Atram
<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail>
Virus-free.www.avast.com
<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail>
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
…On Sat, May 23, 2026 at 11:35 PM Vaishnav Kale ***@***.***> wrote:
*Vaishnav88sk* left a comment (microcks/microcks-cli#406)
<#406 (comment)>
please pass the DCO
—
Reply to this email directly, view it on GitHub
<#406 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BER7XKED5Z2DQFRPQ224A3D44HR73AVCNFSM6AAAAACZCRKFX2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DKMRWGE2TEOBZGY>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a crash path in the
microcks contextcommand when no local config exists yet.Problem
When running
microcks context <context-name>on a fresh machine (or after config cleanup),localCfgcan benil.The command dereferences
localCfg(localCfg.CurrentContext) without a nil guard, which can lead to a nil pointer panic instead of a user-friendly message.Changes
localCfg == nilcheck incmd/context.gobefore first dereference in the context-switch flow.microcks context(no args): still lists contexts / prints existing output path.microcks context --delete ...: unchanged.Result